Collectives Article

ID:: collectives-article
Automated score:: 92
URL:: https://stackoverflow.com/collectives/aws/articles/77217753/code-change-best-practices-smaller-pull-requests-for-smoother-merging

9 violations: Light: 2Dark: 3HC Light: 2HC Dark: 2

aria-required-parent

Light Critical Go to issue aria-required-parent-light

Ensure elements with an ARIA role that require parent roles are contained by them. Certain ARIA roles must be contained by particular parents. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix any of the following:

Required ARIA parents role not present: menu, menubar, group

aria-required-parent

Dark Critical Go to issue aria-required-parent-dark

Ensure elements with an ARIA role that require parent roles are contained by them. Certain ARIA roles must be contained by particular parents. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix any of the following:

Required ARIA parents role not present: menu, menubar, group

aria-required-parent

HC Light Critical Go to issue aria-required-parent-light-highcontrast

Ensure elements with an ARIA role that require parent roles are contained by them. Certain ARIA roles must be contained by particular parents. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix any of the following:

Required ARIA parents role not present: menu, menubar, group

aria-required-parent

HC Dark Critical Go to issue aria-required-parent-dark-highcontrast

Ensure elements with an ARIA role that require parent roles are contained by them. Certain ARIA roles must be contained by particular parents. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix any of the following:

Required ARIA parents role not present: menu, menubar, group

link-in-text-block

Dark Serious Go to issue link-in-text-block-dark

Ensure links are distinguished from surrounding text in a way that does not rely on color. Links must be distinguishable without relying on color. Help URL

HTML

<a href="/contact">contact us</a>

Target

a[href$="contact"]

Summary

Fix any of the following:

The link has insufficient color contrast of 1.75:1 with the surrounding text. (Minimum contrast is 3:1, link text: #90c4f9, surrounding text: #f9fafa)
The link has no styling (such as underline) to distinguish it from the surrounding text

link-name

Light Serious Go to issue link-name-light

Ensure links have discernible text. Links must have discernible text. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix all of the following:

Element is in tab order and does not have accessible text
Fix any of the following:
Element does not have text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute

link-name

Dark Serious Go to issue link-name-dark

Ensure links have discernible text. Links must have discernible text. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix all of the following:

Element is in tab order and does not have accessible text
Fix any of the following:
Element does not have text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute

link-name

HC Light Serious Go to issue link-name-light-highcontrast

Ensure links have discernible text. Links must have discernible text. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix all of the following:

Element is in tab order and does not have accessible text
Fix any of the following:
Element does not have text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute

link-name

HC Dark Serious Go to issue link-name-dark-highcontrast

Ensure links have discernible text. Links must have discernible text. Help URL

HTML

<a href="#" class="s-topbar--menu-btn js-left-sidebar-toggle" role="menuitem" aria-haspopup="true" aria-controls="left-sidebar" aria-expanded="false"><span></span></a>

Target

.s-topbar--menu-btn

Summary

Fix all of the following:

Element is in tab order and does not have accessible text
Fix any of the following:
Element does not have text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute